Improving compatibility with EqSchema for Schema Coercion#5
Merged
Conversation
macielti
changed the title
EqSchema for Schema Coercion
There was a problem hiding this comment.
Pull request overview
This PR improves schema coercion compatibility with EqSchema by automatically converting string values to keywords when expected by the schema, and updates error handling for request body validation with clearer error messages and consistent detail formatting.
Changes:
- Implemented custom
json-matcherfunction to coerce string values to keywords forEqSchemawith keyword values - Updated error handling for request body validation with new error code "invalid-request-body-payload" and improved messages
- Stringified error details in responses for consistency
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/service_component/interceptors.clj | Added json-matcher function for EqSchema coercion; updated wire-in-body-schema error handling with new error code, message, and stringified details |
| test/unit/service_component/interceptors_test.clj | Added tests for EqKeywordSchema coercion covering both successful coercion and validation failure cases |
| test/integration/service_component_test.clj | Updated integration tests to reflect new error code, message format, and stringified error details |
| project.clj | Bumped version from 6.4.3 to 7.4.3 to reflect breaking changes |
| CHANGELOG.md | Documented breaking changes and new schema coercion feature for version 7.4.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
expects a keyword, improving compatibility with EqSchema.